Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

fix clang-tidy issues #123

Merged
merged 3 commits into from
Feb 20, 2024
Merged

fix clang-tidy issues #123

merged 3 commits into from
Feb 20, 2024

Conversation

airMeng
Copy link
Contributor

@airMeng airMeng commented Feb 7, 2024 •
edited
Loading

issues introduced in #121

@airMeng airMeng changed the title fix clang-tidy issues due to https://github.com/intel/neural-speed/pull/121 fix clang-tidy issues Feb 7, 2024
@DDEle DDEle requested a review from VincyZhang February 8, 2024 00:56
@DDEle
Copy link
Contributor

DDEle commented Feb 8, 2024

Added:

  • CI for UTs should check changes of the root CMakeLists.txt, the root setup.py, but ignore all docs
  • CI for format should check changes of the root clang-format.py
  • git ignore CMakeUserPresets.json

DDEle
DDEle approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@DDEle DDEle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@airMeng airMeng merged commit ad54a1f into main Feb 20, 2024
10 checks passed
@airMeng airMeng deleted the fix_clang_tidy branch February 20, 2024 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevinintel kevinintel kevinintel approved these changes

@DDEle DDEle DDEle approved these changes

@VincyZhang VincyZhang Awaiting requested review from VincyZhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@airMeng @DDEle @kevinintel